Add SOQL/SOSL injection guidance to differentiate from SQL #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomas-bartlett
added
enhancement
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds SOQL/SOSL injection guidance to the input validation rule to differentiate Salesforce query injection from traditional SQL injection. The changes include adding Apex language support and documenting security best practices specific to Salesforce's query languages.
Changes:
- Added Apex language mapping with
.clsand.triggerfile extensions tosrc/language_mappings.py - Added comprehensive SOQL/SOSL injection prevention guidance to the input validation rule
- Updated rule description to include SOQL in addition to SQL/LDAP/OS injection types
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/language_mappings.py |
Added Apex language with correct file extensions (.cls, .trigger) |
skills/software-security/rules/codeguard-0-input-validation-injection.md |
Added SOQL/SOSL injection section and updated description to include SOQL |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
skills/software-security/rules/codeguard-0-input-validation-injection.md
Show resolved
Hide resolved
skills/software-security/rules/codeguard-0-input-validation-injection.md
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new SOQL/SOSL Injection section to the input validation rule that differentiates Salesforce query injection from traditional SQL injection.