Skip to content

Conversation

@eemeli
Copy link
Member

@eemeli eemeli commented Dec 30, 2025

Vitest provides out-of-the-box pretty much everything we're doing with both Mocha and Jest, and requires much less configuration. Also, it lets us easily test the source code, rather than requiring everything to be compiled.

@eemeli eemeli requested a review from mathjazz December 30, 2025 22:52
Copy link

@mathjazz mathjazz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very straightforward.

LocalizationProvider,
Localized,
} from "../esm/index.js";
import { vi } from "vitest";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see jest is available as a global, but vitest need to be imported. No strong preference for either approach here, just curious if this is the the different default behavior of the libraries or a deliberate change.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a deliberate difference between the libraries: https://vitest.dev/guide/migration.html#globals-as-a-default

@eemeli eemeli merged commit f9ed46e into main Jan 8, 2026
3 checks passed
@eemeli eemeli deleted the vitest branch January 8, 2026 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants