Skip to content

Fix Ignored Dict Keys in Agent Portrayal #2918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ShreyasN707 wants to merge 12 commits into
base: main
Choose a base branch
from
+2 −7
Open

Fix Ignored Dict Keys in Agent Portrayal #2918

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
253e4e4
solved the warning issues
ShreyasN707 Dec 2, 2025
2b8f43b
Fixed the warnings of files in issue 2.2
ShreyasN707 Dec 3, 2025
3863507
Fix Ignored Dict Keys in Agent Portrayal
ShreyasN707 Dec 3, 2025
af50e21
Merge branch 'main' into issue-2.3
ShreyasN707 Dec 3, 2025
49f1b33
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 3, 2025
604521c
fixed the visualization import issue
ShreyasN707 Dec 4, 2025
536ded9
tests: expect FutureWarning for simulator.time deprecation (match run…
ShreyasN707 Dec 4, 2025
ee42046
Merge branch 'projectmesa:main' into issue-2.3
ShreyasN707 Dec 4, 2025
564f750
updated the tests to use new versions
ShreyasN707 Dec 4, 2025
42177be
Merge branch 'main' into issue-2.3
EwoutH Dec 4, 2025
162c0a9
Merge branch 'main' into issue-2.3
ShreyasN707 Dec 5, 2025
477bd64
Merge branch 'main' into issue-2.3
ShreyasN707 Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mesa/visualization/mpl_space_drawing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ def draw_space(
Returns the Axes object with the plot drawn onto it.
``agent_portrayal`` is called with an agent and should return a AgentPortrayalStyle. Valid fields in this object are "color",
"size", "marker", "zorder", alpha, linewidths, and edgecolors. Other field are ignored and will result in a user warning.
"size", "marker", "zorder", "alpha", "linewidths", and "edgecolors". Other field are ignored and will result in a user warning.
"""
if ax is None:
Expand Down
7 changes: 1 addition & 6 deletions tests/test_components_matplotlib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,7 @@


def agent_portrayal(agent):
"""Simple portrayal of an agent.

Args:
agent (Agent): The agent to portray

"""
"""Return a simple AgentPortrayalStyle for testing matplotlib drawing."""
return AgentPortrayalStyle(
size=10,
color="tab:blue",
Expand Down
4 changes: 3 additions & 1 deletion tests/test_devs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,9 @@ def test_simulator_time_deprecation():
model = Model()
simulator.setup(model)

with pytest.warns(DeprecationWarning, match="simulator.time is deprecated"):
# The runtime now emits a FutureWarning for this deprecation.
# Update test to match the current warning type.
with pytest.warns(FutureWarning, match="simulator.time is deprecated"):
Copy link
Member

@EwoutH EwoutH Dec 4, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this. This was a bit time pressing however, so I already fixed it in #2922.

Copy link
Contributor Author

@ShreyasN707 ShreyasN707 Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay! Since the fix is handled, I’ll update my branch accordingly and focus this PR only on the agent portrayal changes.
Let me know if anything else needs adjustment!

_ = simulator.time


Expand Down