Include created timestamp in protobuf output format#1182
Include created timestamp in protobuf output format#1182mantuu wants to merge 2 commits intoprometheus:mainfrom
Conversation
| this(false); | ||
| } | ||
|
|
||
| public PrometheusProtobufWriter(boolean writeCreatedTimestamps) { |
There was a problem hiding this comment.
I'd like to avoid boolean params - let's use a builder instread
There was a problem hiding this comment.
Should this even be configurable? It makes sense to make timestamps configurable in text format, because in text format timestamps end up as extra time series which cause extra load on the Prometheus server.
However, in protobuf format time stamps do not cause extra cost, so we could just enable them always, right?
There was a problem hiding this comment.
@fstab This makes sense. It should make almost no difference in protobuf. So I am thinking of removing the boolean-constructor (@zeitlinger) and make protobuf always include the created-timestamp (as long it is not null).
|
@mantuu do you want to give it a go? |
3 participants
Hi, this is actually needed for the feature "created-timestamp-zero-ingestion", which work with the protobuf-protocoll.