Adds ability to exclude deadlocked threads from exported metrics#612
Open
askoog wants to merge 3 commits intoprometheus:mainfrom
Open
Adds ability to exclude deadlocked threads from exported metrics#612askoog wants to merge 3 commits intoprometheus:mainfrom
askoog wants to merge 3 commits intoprometheus:mainfrom
Conversation
Finding deadlocked threads might be an expensive operation if there are a large number of threads in the jvm since it requires a safepoint.
Finding deadlocked threads might be an expensive operation if there are a large number of threads in the jvm since it requires a safepoint. Signed-off-by: Andreas Skoog <andreas.skoog@avanza.se>
git@github.com:askoog/client_java.git into optional-deadlocked-threads-metric Signed-off-by: Andreas Skoog <andreas.skoog@avanza.se>
askoog
force-pushed
the
optional-deadlocked-threads-metric
branch
from
ffa9616 to
1afba44
Compare
Contributor
brian-brazil
left a comment
brian-brazil
left a comment
There was a problem hiding this comment.
How would the user access the object to call this?
| */ | ||
| public class ThreadExports extends Collector { | ||
| private final ThreadMXBean threadBean; | ||
| private boolean includeDeadlockedThreads = true; |
Author
There was a problem hiding this comment.
Locking in what way? Better to set it in overloaded constructor?
Contributor
There was a problem hiding this comment.
That's one option, this can be accessed and mutated concurrently which is the issue. You could also split this out to a completely separate collector.
Author
I suppose you need to do instantiate the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finding deadlocked threads might be an expensive operation if there are
a large number of threads in the jvm since it requires a safepoint.