avoid unnecessary ArrayList creations; use Collections.singletonList …#906
Open
ispringer wants to merge 1 commit intoprometheus:mainfrom
Open
avoid unnecessary ArrayList creations; use Collections.singletonList …#906ispringer wants to merge 1 commit intoprometheus:mainfrom
ispringer wants to merge 1 commit intoprometheus:mainfrom
Conversation
…rather than Arrays.asList where possible Signed-off-by: Ian Springer <ian.springer@salesforce.com>
fstab
reviewed
Dec 18, 2023
Member
fstab
left a comment
There was a problem hiding this comment.
Thanks a lot for the PR! To be honest, I find immutability in Java really hard. For example, take the following code:
String[] excludedName = new String[1];
excludedName[0] = "some name";
ExporterFilterProperties filter1 = ExporterFilterProperties.builder().excludedNames(excludedName).build();
excludedName[0] = "some other name";
ExporterFilterProperties filter2 = ExporterFilterProperties.builder().excludedNames(excludedName).build();To be fair, it's a contrived example.
However, if we don't copy the array then filter1 will be altered after it was created, so it won't be immutable.
I don't see a good way to avoid this other than creating copies of the arrays.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…rather than Arrays.asList where possible