feat(om2): classic histogram and summary as complex types#2679
Merged
feat(om2): classic histogram and summary as complex types#2679
Conversation
krajorama
changed the title
krajorama
force-pushed
the
krajo/om2.0-complex-hist-summ
branch
from
aca6583 to
4c7a987
Compare
krajorama
commented
Jun 16, 2025
dashpole
previously approved these changes
Jun 17, 2025
bwplotka
previously approved these changes
Sep 4, 2025
Member
bwplotka
left a comment
bwplotka
left a comment
There was a problem hiding this comment.
I would love that, but as we discussed on our sync - we need a bigger decision if we want to follow this path.
If we do, we likely need some rough uncomplex inlined format explained that is not meant to be used for scraping and can be surfaced with promtool etc.
krajorama
dismissed stale reviews from bwplotka and dashpole
this is a draft, changes incoming, also I made a mistake with the quantile values
dashpole
previously approved these changes
Oct 3, 2025
bwplotka
added a commit
to prometheus/prometheus
that referenced
this pull request
Oct 7, 2025
This change is for demo purposes, exploring the benefits (and downsides) for the complex type format for OM2 captured in prometheus/docs#2679. This assumes Prometheus stores NS and NHCB (and NH) going forward (for best case efficiency), but is expected to work for classic mode too with little overhead (benchmarks will tell us). Part of the PromCon talk we do with @krajorama Signed-off-by: bwplotka <bwplotka@gmail.com>
bwplotka
added a commit
to prometheus/prometheus
that referenced
this pull request
Oct 7, 2025
This change is for demo purposes, exploring the benefits (and downsides) for the complex type format for OM2 captured in prometheus/docs#2679. This assumes Prometheus stores NS and NHCB (and NH) going forward (for best case efficiency), but is expected to work for classic mode too with little overhead (benchmarks will tell us). Part of the PromCon talk we do with @krajorama Signed-off-by: bwplotka <bwplotka@gmail.com>
bwplotka
added a commit
to prometheus/prometheus
that referenced
this pull request
Oct 7, 2025
This change is for demo purposes, exploring the benefits (and downsides) for the complex type format for OM2 captured in prometheus/docs#2679. This assumes Prometheus stores NS and NHCB (and NH) going forward (for best case efficiency), but is expected to work for classic mode too with little overhead (benchmarks will tell us). Part of the PromCon talk we do with @krajorama Signed-off-by: bwplotka <bwplotka@gmail.com>
Member
|
Results are (expectedly) impressive: prometheus/prometheus#17293 One observation is that buckets are a bit dense (readability). However we don't have spaces in any other place (e.g. labels) |
bwplotka
added a commit
to prometheus/prometheus
that referenced
this pull request
Oct 7, 2025
This change is for demo purposes, exploring the benefits (and downsides) for the complex type format for OM2 captured in prometheus/docs#2679. This assumes Prometheus stores NS and NHCB (and NH) going forward (for best case efficiency), but is expected to work for classic mode too with little overhead (benchmarks will tell us). Part of the PromCon talk we do with @krajorama Signed-off-by: bwplotka <bwplotka@gmail.com>
krajorama
force-pushed
the
krajo/om2.0-complex-hist-summ
branch
from
8696022 to
8c8eeae
Compare
krajorama
force-pushed
the
krajo/om2.0-complex-hist-summ
branch
7 times, most recently
from
10e9bef to
181db08
Compare
bwplotka
reviewed
Dec 17, 2025
bwplotka
reviewed
Dec 17, 2025
Contributor
|
This looks good to me overall. I think we can save float histograms for a follow-up. |
bwplotka
reviewed
Jan 14, 2026
bwplotka
reviewed
Jan 14, 2026
bwplotka
reviewed
Jan 14, 2026
Ref: prometheus/OpenMetrics#283 Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
krajorama
force-pushed
the
krajo/om2.0-complex-hist-summ
branch
from
181db08 to
578ba94
Compare
bwplotka
reviewed
Jan 28, 2026
Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com> Signed-off-by: George Krajcsovits <krajorama@users.noreply.github.com>
dashpole
reviewed
Jan 29, 2026
dashpole
approved these changes
Jan 29, 2026
Contributor
dashpole
left a comment
dashpole
left a comment
There was a problem hiding this comment.
lgtm after comment addressed
Say exemplars, not exemplar. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
krajorama
force-pushed
the
krajo/om2.0-complex-hist-summ
branch
from
b3a8ea8 to
f143b5f
Compare
Member
|
The failure relates to AM release... 🤔 7:00:32 AM: Checking out release-0.31 of prometheus/alertmanager from ./generated/repos/prometheus/alertmanager.git into /opt/build/repo/generated/repo-docs/prometheus/alertmanager/0.31... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: prometheus/OpenMetrics#283
It isn't hard to come up with a representation, based on previous work in https://github.com/prometheus/proposals/blob/main/proposals/2024-01-29_native_histograms_text_format.md .