mountstats/linux: fix multiple transports statistics labeling#3358
Open
sagigrimberg wants to merge 2 commits intoprometheus:masterfrom
Open
mountstats/linux: fix multiple transports statistics labeling#3358sagigrimberg wants to merge 2 commits intoprometheus:masterfrom
sagigrimberg wants to merge 2 commits intoprometheus:masterfrom
Conversation
Author
Author
|
@discordianfish @SuperQ ping again..... must be a sad joke... |
Member
|
@sagigrimberg Whats the intention? Why do you need individual metrics per transport? Not familiar with nconnect |
Author
|
@discordianfish Sorry for the super long delay - I stopped checking this PR frequently. The intention is to support nconnect mount option in NFS. Which creates multiple connections (transports). Currently any nconnect>1 breaks the exporter. |
When mounting nfs with nconnect, mountstats will show multiple transports. Currently the mountstats exporter fails to create metrics from this information due to repeated entries. Fix this by adding transport metrics a "transport" label enumerating their order in the mountstats output. Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
sagigrimberg
force-pushed
the
sagi/fix-nfs-multi-xprt
branch
from
566270c to
53503f8
Compare
Author
|
@discordianfish @SuperQ ping |
4 similar comments
Author
|
@discordianfish @SuperQ ping |
Author
|
@discordianfish @SuperQ ping |
Author
|
@discordianfish @SuperQ ping |
Author
|
@discordianfish @SuperQ ping |
Author
|
@discordianfish @SuperQ ping |
1 similar comment
Author
|
@discordianfish @SuperQ ping |
Author
|
Thank you. So you will merge this branch? |
Author
|
@discordianfish @SuperQ can this PR be merged please? |
Author
|
@discordianfish @SuperQ ping |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When mounting nfs with nconnect, mountstats will show multiple transports. Currently the mountstats exporter fails to create metrics from this information due to repeated entries.
Fix this by adding transport metrics a "transport" label enumerating their order in the mountstats output.