Add filesystem UUID based filter#3384
Add filesystem UUID based filter#3384erjavaskivuori wants to merge 1 commit intoprometheus:masterfrom
Conversation
42adf18 to
6efaa70
Compare
6efaa70 to
9f925e6
Compare
9f925e6 to
f5bf4ab
Compare
|
@SuperQ can we have reviews on this one? |
Add filesystem UUID based filter to filesystem collector. Co-authored-by: Adam Rozman <adam.rozman@est.tech> Signed-off-by: erjavaskivuori <erja.vaskivuori@est.tech> Signed-off-by: Adam Rozman <adam.rozman@est.tech>
|
@SuperQ I have took over this PR and I have also re-based it. Would it be possible to get some review on this PR? |
|
Adding @discordianfish too, please take a look. |
|
Not completely opposed but also not convinced this is needed. You could use a wrapper script to lookup the mountpoints from the uuids and then invoke the node-exporter with the right mountpoint. @SuperQ wdyt? |
|
Ah hah, see #3400 |
Add filesystem UUID based filter to the
filesystemCollectorThe implementation currently only includes Linux and I would be glad to hear feedback before continuing to implement this for other OS' file system collectors.
I tried to create unit test for the
buildUUIDMapfunction but couldn't figure out how could I create device major:minor for the fixture block device nodes that I tried to add. So currently there is no test for this feature. I have tested this locally.Fixes #3380