Fix frag shader parser bug #156
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shagkur any chance this could be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cgcomp will segfault for some fragment shaders. This is caused by a bug in the parser that tokenizes nv40 asm in order to create an rsx compatible binary.
Example:
The problem was with parsing oCol dst mask. It would get tokenized as 'oCol(' which is not a valid token . The reg variable would not get set which causes a segfault later in processing.
Reading the code, its clear the intent was to skip over the oCol token, then parser.cpp line 232 would hit the paren and parse condition instructions.
PR also here for this fork maintained by scummvm team that is still active ps3aqua#2