[SIGNAL] Moved certain warnings to debug level #3302
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptitSeb
reviewed
Dec 23, 2025
| #endif | ||
| } | ||
| printf_log(LOG_INFO, "Warning, context has been changed in Sigactionhanlder%s\n", (sigcontext->uc_mcontext.gregs[X64_RIP]!=sigcontext_copy.uc_mcontext.gregs[X64_RIP])?" (EIP changed)":""); | ||
| printf_log(LOG_DEBUG, "Warning, context has been changed in Sigactionhanlder%s\n", (sigcontext->uc_mcontext.gregs[X64_RIP] != sigcontext_copy.uc_mcontext.gregs[X64_RIP]) ? " (EIP changed)" : ""); |
Owner
There was a problem hiding this comment.
this one should stay at LOG_INFO, but the message is incomplete: it should mention that there is no jmpbuffer ready (and so the new RIP will not be satisfied)
Collaborator
Author
There was a problem hiding this comment.
This is the one repeated forever.
Owner
There was a problem hiding this comment.
Then there is a real issue. This specific message is an error, not a warning.
Owner
There was a problem hiding this comment.
Those message appear when the signal should have be resumed using a siglongjmp, but the jumpbuffer is not available for some reason. This is not ok to continue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.