Open
Conversation
Author
|
Also I gotta mention the Python script is not pretty per se, but gets the job done |
pedro-psb
requested changes
Feb 4, 2026
Member
pedro-psb
left a comment
pedro-psb
left a comment
There was a problem hiding this comment.
There are some linting errors.
I'm not sure if I'll have to allow the workflow again... I'll be watching
| version_str = match.group(1) | ||
| print("") | ||
| print("> [!NOTE]") | ||
| print(f"> Changes are also available on [Pulp docs](https://pulpproject.org/pulpcore/changes/#{version_str})") |
Member
There was a problem hiding this comment.
This runs against all Pulp plugins, so you can't hardcode pulpcore here.
You can either make this script a template (.j2) and use {{ plugin_name }} or pass as an argument trough publish.yml.j2, which is already a template.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up of pulp/pulpcore#7279, with the suggestions from @pedro-psb applied here