Make plugin_template command uv compatible#1005
Merged
Conversation
mdellweg
force-pushed
the
cleanup
branch
3 times, most recently
from
ea68805 to
e09d695
Compare
gerrod3
requested changes
Feb 11, 2026
Contributor
gerrod3
left a comment
gerrod3
left a comment
There was a problem hiding this comment.
What's the reasoning to move to jamldump?
|
|
||
| # generated with plugin_template | ||
| # | ||
| # After editing this file please always reapply the plugin template befor committing any changes. |
|
|
||
| if "github" in sections: | ||
| migrate_dummy(plugin_root_dir) | ||
| remove_deprecated_files(plugin_root_dir, sections) |
Contributor
There was a problem hiding this comment.
We're removing files now? That's cool. Edit NVM we already were, now the function is properly named.
plugin-template
Outdated
| config (dict): a dictionary containing a default template configuration for the plugin | ||
| """ | ||
| if plugin_app_label is None: | ||
| plugin_app_label = plugin_app_label or plugin_name.removeprefix("pulp").replace( |
Contributor
There was a problem hiding this comment.
I think the or statement needs to be removed or you remove the previous if statement.
| """ | ||
| session = requests_cache.CachedSession(".requests_cache", expire_after=timedelta(days=1)) | ||
| session = requests_cache.CachedSession( | ||
| Path(__file__).parent / ".requests_cache", expire_after=timedelta(days=1) |
Contributor
There was a problem hiding this comment.
Why put it in the parent directory?
Member
Author
There was a problem hiding this comment.
The parent of file is the directory so this will land exactly here.
Member
Author
|
jamldump is writing yaml in the style that we have (mostly) adopted in the other yml files here. |
gerrod3
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.