Open
Conversation
Member
|
@gerrod3 your changes affects the Also, can we have backport to 2.19 |
rochacbruno
reviewed
Feb 23, 2026
|
|
||
| # if more chunks | ||
| if range_header: | ||
| chunk = ContentFile(chunk.read()) |
Member
There was a problem hiding this comment.
isn't this getting a larger chunk?
Contributor
Author
|
@rochacbruno Read my initial comment on the different scenarios of chunked upload. If a PATCH chunk upload is sent that is larger than we can handle and doesn't fall under the special podman case then we are out of luck. Someone needs to fix their client to adhere to the spec or set their chunking size to a smaller value. |
Contributor
Author
|
The most we can do is maybe introduce a setting that checks the size of the chunk and if over a certain amount return a 4XX error that the chunk is too large for a PATCH request, use a smaller size. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the spec there are two ways to perform monolithic blob pushes:
There's an unofficial third way that podman can apparently do according to our comments which is:
The code should now call our special large chunk handler for all three cases, we were forgetting case number 2. Note that depending on the client they could still cause the server to go OOM if they send ridiculously large chunks in the normal chunked upload path since we read the entire chunk into memory before saving it. There is nothing we can do here as part of the code lives in pulpcore, but honestly what is that client thinking sending such large chunks!
📜 Checklist
See: Pull Request Walkthrough