Add attestation upload support #1038
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gerrod3
force-pushed
the
twine-attestation
branch
from
8c3823d to
1ff7d38
Compare
jobselko
reviewed
Dec 5, 2025
gerrod3
force-pushed
the
twine-attestation
branch
3 times, most recently
from
632c86e to
e9f1531
Compare
jobselko
reviewed
Dec 5, 2025
jobselko
reviewed
Dec 5, 2025
gerrod3
force-pushed
the
twine-attestation
branch
2 times, most recently
from
d3e65db to
6a8bd94
Compare
jobselko
reviewed
Dec 9, 2025
jobselko
reviewed
Dec 9, 2025
gerrod3
force-pushed
the
twine-attestation
branch
from
6a8bd94 to
f77550f
Compare
jobselko
approved these changes
Dec 9, 2025
Contributor
jobselko
left a comment
jobselko
left a comment
There was a problem hiding this comment.
I will not have enough time today to check the entire attestation.md file, but we can make adjustments later if needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of changes to get the last part of PEP 740 implemented. This adds the field
attestationsto the package upload serializer and the twine upload serializer ,that takes a json list of Attestations to create a Provenance object for the package.The big changes with this PR is around the library we are using for validation/verification, pypi-attestations. This library is designed for PyPI and thus has the assumptions of PyPI. The big ones are 1. Attestations are only uploaded from TrustedPublishers and 2. only select TrustedPublishers are supported (GitHub, Gitlab, Google). We don't have TrustedPublishers and we want to support any type of Publisher, hence the modified Publisher type: ExtendedPublisher, that will act as a fallback.
fixes: #740
https://issues.redhat.com/browse/PULP-975