Skip to content

Conversation

@gerrod3
Copy link
Contributor

@gerrod3 gerrod3 commented Mar 24, 2025

@gerrod3 gerrod3 force-pushed the pt-save branch 3 times, most recently from abbd22a to 14208f4 Compare March 24, 2025 20:30
Copy link
Member

@bmbouter bmbouter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me!

@@ -0,0 +1,2 @@
Added support for automatically saving pull-through content to a repository.
Requires pulpcore 3.74 or later.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where's the lower bound bump? pyproject.toml needs updating.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we don't. If you have >=3.74 then you get the new behavior, else you don't.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, that wasn't clear. Thanks

@gerrod3 gerrod3 merged commit 025b576 into pulp:main Apr 8, 2025
12 checks passed
@gerrod3 gerrod3 deleted the pt-save branch April 8, 2025 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable pull-through-cache adds to repo version

3 participants