Skip to content

Conversation

@jobselko
Copy link
Contributor

This PR replaces the deprecated license classifiers with an SPDX license expression. See https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#license for details.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized that this repository specifies requires = ["setuptools >= 40.8.0", "wheel >= 0.29.0"], but support for SPDX license expressions was added in setuptools v77.0.0 (https://setuptools.pypa.io/en/latest/history.html#v77-0-0), so my change is not compatible with the current build requirements, and will close this PR.

Out of curiosity, is there a chance we will be updating the build requirements in the near future?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohhh and v77.0.0 19 Mar 2025 is quite a bit recent.
Maybe if you had a chat with the build folks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will check with them in the next Integration scrum meeting and then decide on the next steps.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now EL9 ships with 68.2 for python3.12, it's even older for 3.11.

@jobselko jobselko marked this pull request as draft May 10, 2025 14:05
@jobselko
Copy link
Contributor Author

jobselko commented Jul 7, 2025

Closing, since the required changes are not worth it.

@jobselko jobselko closed this Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants