Skip to content

Conversation

@jobselko
Copy link
Contributor

This PR updates the user docs with the following changes:

  • more detailed commands and updated output to reflect new fields
  • typo fixes
  • formatting improvements

@jobselko jobselko self-assigned this May 10, 2025
@jobselko jobselko marked this pull request as ready for review May 12, 2025 08:08
Copy link
Member

@pedro-psb pedro-psb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Edit: oh, didn't see ggainey nit. I hope we can implement some lint/auto-format for docs this year.
I briefly experimented with a lib but it needs some more planning and discussion. Looks like it (mdformat) has plugins to auto-format code-blocks, for example.

@jobselko jobselko marked this pull request as draft May 14, 2025 14:18
@jobselko
Copy link
Contributor Author

@pedro-psb Having a Markdown formatter would be great for keeping the docs consistent. But I think we would also need something like ShellCheck to detect syntax errors, common pitfalls, and similar issues. I am not sure if mdformat has a plugin for that.

@jobselko jobselko marked this pull request as ready for review May 15, 2025 10:43
@pedro-psb
Copy link
Member

I am not sure if mdformat has a plugin for that.

It has plugins for shfmt but not shellcheck.
https://mdformat.readthedocs.io/en/stable/users/plugins.html#existing-plugins

@jobselko jobselko requested a review from ggainey May 16, 2025 13:54
@ggainey ggainey merged commit 6f2947c into pulp:main May 16, 2025
12 checks passed
@jobselko jobselko deleted the update_docs branch July 23, 2025 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants