Support on-demand content in repair_metadata #848
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jobselko
force-pushed
the
repair_on_demand_content
branch
4 times, most recently
from
fc1102d to
99180e4
Compare
jobselko
force-pushed
the
repair_on_demand_content
branch
8 times, most recently
from
9e27aaf to
04c2e4f
Compare
jobselko
force-pushed
the
repair_on_demand_content
branch
2 times, most recently
from
9875d50 to
925e392
Compare
jobselko
changed the title
jobselko
force-pushed
the
repair_on_demand_content
branch
2 times, most recently
from
2b14e83 to
79d7acf
Compare
jobselko
force-pushed
the
repair_on_demand_content
branch
from
79d7acf to
b2b74fa
Compare
jobselko
force-pushed
the
repair_on_demand_content
branch
2 times, most recently
from
42e9834 to
0b91e31
Compare
jobselko
commented
May 22, 2025
jobselko
force-pushed
the
repair_on_demand_content
branch
2 times, most recently
from
7c3cb5c to
95f6e5f
Compare
gerrod3
requested changes
Jun 2, 2025
Contributor
gerrod3
left a comment
gerrod3
left a comment
There was a problem hiding this comment.
Good work on the logic, the grouping of the packages by name-version and then further grouping by shared url of the RAs looks right (it is definitely a bit complex!)
jobselko
force-pushed
the
repair_on_demand_content
branch
from
95f6e5f to
b0b12d9
Compare
github-actions
bot
added
multi-commit
jobselko
force-pushed
the
repair_on_demand_content
branch
from
b0b12d9 to
308b353
Compare
jobselko
commented
Jun 4, 2025
jobselko
force-pushed
the
repair_on_demand_content
branch
from
308b353 to
1cdff86
Compare
jobselko
commented
Jun 4, 2025
gerrod3
requested changes
Jun 9, 2025
jobselko
force-pushed
the
repair_on_demand_content
branch
2 times, most recently
from
ab59d2d to
ecb804f
Compare
jobselko
force-pushed
the
repair_on_demand_content
branch
from
ecb804f to
154f96a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the
repair_metadataendpoint for repositories to also support on-demand content if the associated remote supports the PyPI json version API.For on-demand content, we expect that:
PythonPackageContentalways has correctnameandversionRemoteArtifactalways has correctsha256Closes #849