Skip to content

Conversation

@gerrod3
Copy link
Contributor

@gerrod3 gerrod3 commented May 14, 2025

fixes: #842

@MichelPoppema Was this the fix you tested?

@MichelPoppema
Copy link

MichelPoppema commented May 15, 2025

I've tested only the change in line 265 (https://community.sonatype.com/t/nexus-3-as-a-pypi-mirror-how-do-i-get-the-json-data-for-a-given-package/13448 states Nexus only supports https://peps.python.org/pep-0503/)

Copy link
Contributor

@jobselko jobselko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but it would be good to add a test for it if it is easy to do so

@gerrod3 gerrod3 merged commit ebf7b2c into pulp:main Jun 2, 2025
12 checks passed
@patchback
Copy link

patchback bot commented Jun 2, 2025

Backport to 3.15: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.15/ebf7b2c0b0788ba84a45504dc27a66b74b255900/pr-852

Backported as #859

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@gerrod3 gerrod3 deleted the pt-relative branch June 2, 2025 19:07
patchback bot pushed a commit that referenced this pull request Jun 2, 2025
Fix pull-through caching for indexes with relative urls

(cherry picked from commit ebf7b2c)
ggainey added a commit that referenced this pull request Jun 4, 2025
…788ba84a45504dc27a66b74b255900/pr-852

[PR #852/ebf7b2c0 backport][3.15] Fix pull-through caching for indexes with relative urls
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pull through caching with relative href urls in HTML results in 404

3 participants