Skip to content

Add black #875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jobselko merged 4 commits into from
Jul 30, 2025
Merged

Add black #875

jobselko merged 4 commits into from
Jul 30, 2025

Conversation

@dosas
Copy link
Contributor

@dosas dosas commented Jun 26, 2025

Linting in the oci_env requires black to be present

@github-actions github-actions bot added multi-commit Add to bypass single commit lint check no-changelog no-issue labels Jun 26, 2025
@jobselko
Copy link
Contributor

jobselko commented Jul 16, 2025

Hi! Thank you for your contribution. Do you need any assistance from us to move things forward?

dosas added 2 commits July 17, 2025 07:31
@dosas
Add black linting using
a6cdac9 
./plugin-template --github pulp_python
@dosas
Set line limit for black to the same value as flake8
389c466 
This should be added automatically by the plugin_template
@dosas dosas force-pushed the upstream/add-black branch from a640895 to 988c436 Compare July 17, 2025 05:34
@dosas
Copy link
Contributor Author

dosas commented Jul 17, 2025

Hi! Thank you for your contribution. Do you need any assistance from us to move things forward?

Hi, I cannot assign a reviewer. So a reviewing or assigning one would really help.

@jobselko
Copy link
Contributor

jobselko commented Jul 18, 2025

@dosas I will try to review it next week.

@jobselko jobselko marked this pull request as ready for review July 18, 2025 11:51
jobselko
jobselko requested changes Jul 25, 2025
View reviewed changes
@dosas dosas force-pushed the upstream/add-black branch from 988c436 to 4aeda89 Compare July 30, 2025 08:41
@dosas dosas requested a review from jobselko July 30, 2025 08:41
@dosas
Copy link
Contributor Author

dosas commented Jul 30, 2025

@jobselko Thank you for your review.
What is next? Do we need another approval? I have no rights to merge this MR.

@jobselko
Copy link
Contributor

jobselko commented Jul 30, 2025

@jobselko Thank you for your review. What is next? Do we need another approval? I have no rights to merge this MR.

I will ask my colleagues if they want to look at it, but I think it could be merged today.

@jobselko jobselko merged commit 671a3d3 into pulp:main Jul 30, 2025
13 checks passed
@jobselko
Copy link
Contributor

jobselko commented Jul 30, 2025

@dosas How urgent is the release of this PR?

@dosas
Copy link
Contributor Author

dosas commented Jul 30, 2025

@dosas How urgent is the release of this PR?

not urgent at all

@jobselko
Copy link
Contributor

jobselko commented Jul 30, 2025

@dosas How urgent is the release of this PR?

not urgent at all

Okay, this will be included in the next release. If you need it earlier for any reason, just ping us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jobselko jobselko jobselko approved these changes

Assignees

No one assigned

Labels

multi-commit Add to bypass single commit lint check no-changelog no-issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dosas @jobselko