Fix publish failure when handling bad dist name metadata #962
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gerrod3
force-pushed
the
mismatch-names
branch
from
ad9ad2a to
e14b800
Compare
dralley
approved these changes
Sep 13, 2025
Backport to 3.19: 💚 backport PR created✅ Backport PR branch: Backported as #969 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Sep 14, 2025
Fix publish failure when handling bad dist name metadata (cherry picked from commit 30e5999)
gerrod3
added a commit
that referenced
this pull request
Sep 14, 2025
…86e1c7a2e6221cd5881afe54cb3fb3/pr-962 [PR #962/30e5999a backport][3.19] Fix publish failure when handling bad dist name metadata
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #907
A weird edge case that I'm unsure if this is the best way to handle it. The metadata in the package is "incorrect" that the SDist and Wheel names don't match (see test example). PyPI accepts both packages and sets the metadata in the json api correctly so if you sync these packages the publish would work fine, but if you uploaded them then the publish would fail since the packages would have different wheel names.