Conversation
confused-Techie
left a comment
confused-Techie
left a comment
There was a problem hiding this comment.
As discussed on Discord, I think this looks great, and totally love the changes being made here
|
Does anyone else from @pulsar-edit/documentation want to take a review of this one or are we good to merge? |
|
Alright, with not much activity happening here, or seen on Discord, how do we feel about merging this one? |
|
I kinda liked the blue, but most people who commented seemed to like the purple, so sure. 👍 I think the majority has it (even if the sample size was pretty small). And we can always keep refreshing it as time goes on. |
|
Its very much just a temporary thing until we have our branding clear, I think its better than the green either way, |
meadowsys
left a comment
meadowsys
left a comment
There was a problem hiding this comment.
I like the purple! and yeah, at the very least its a bit more consistent with some things (like GH org icon, Discord server icon, app icon etc)
4 participants
Current theme colour (default theme green) is a bit jarring, especially with the purple home page. The original plan was to wait for the branding and do this in one go but that seems to be taking a while.
This is really just a "one size fits all" temporary fix, just one css value which affects a bunch of stuff such as the footer, the hero text, mouseover accents, hyperlinks etc.
This purple is the same one from the package Dracula theme (
#ae88e5). Suggestions welcome as this is very easy to change - for example I can see objection to how it looks on the light theme, maybe this should be darkened a tad?