Add facilities to explore the registry package sets from the CLI #1370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ] | ||
| } | ||
| { db } <- ask | ||
| entries <- liftEffect $ Db.selectPackageSetEntriesBySet db setVersion |
Member
There was a problem hiding this comment.
Looks like this is reading directly from the database without a prior getRegistry or fetchRegistry — the Nothing branch calls Registry.listPackageSets so that's ok bc it hydrates the daatabase, but this branch doesn't. Do we need to make sure this branch ensures we're up-to-date in the db, or is that happening somewhere else?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1218: in this PR we add the
spago registry package-sets $SETcommand, to explore the contents of each package set, together with the package set information for each package when callingspago registry info $PACKAGE