Skip to content

enh: final cleanup #773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lwasser merged 1 commit into from
Dec 19, 2025
Merged

enh: final cleanup #773

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
112 changes: 51 additions & 61 deletions _includes/package-grid.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,65 +1,55 @@
<div class="element-item cards bubble {% for aCategory in apackage.categories %}
<div class="element-item package-card {% for aCategory in apackage.categories %}
{{ aCategory }}
{% endfor %}" data-category="data">
<article itemscope itemtype="https://schema.org/SoftwareApplication">
<h3 class="card__title no_toc" itemprop="name">
{{ apackage.package_name }}
</h3>
<p class="page__meta contributors">
<span><i class="fas fa-feather" aria-hidden="true"></i>
{% if apackage.all_current_maintainers %}
{% for maintainer in apackage.all_current_maintainers %}
<a href="https://github.com/{{ maintainer.github_username }}" rel="maintainer" target="_blank">
{% if maintainer.name %}
{{ maintainer.name }}{% if forloop.last == false %},{% endif %}
{% else %}
{{ maintainer.github_username }}{% if forloop.last == false %},{% endif %}
{% endif %}
</a>
{% endfor %}
{% elsif apackage.submitting_author.name != 'Name' %}
<a href="https://github.com/{{ apackage.submitting_author.github_username }}" rel="maintainer" target="_blank">
{{ apackage.submitting_author.name }}
</a>
{% else %}
<a href="https://github.com/{{ apackage.submitting_author.github_username }}" rel="maintainer" target="_blank">
{{ apackage.submitting_author.github_username }}
</a>
{% endif %}
</span>
</p>
<span class="package_description">
<p itemprop="description">
{{ apackage.package_description | markdownify }}
</p>
</span>
<ul>
<li><a href="{{ apackage.repository_link }}" rel="permalink"><i class="fab fa-github"></i> View Code</a></li>
{% if apackage.gh_meta.documentation %}
<li><a href="{{ apackage.gh_meta.documentation }}" rel="permalink"><i class="fas fa-book-open"></i> View Docs</a></li>
{% endif %}
{% if apackage.citation-link %}
<li><a href="{{ apackage.archive }}" rel="permalink"><i class="fas fa-bookmark fa-fw"></i> Cite</a></li>
{% endif %}
<li><a href="{{ apackage.issue_link }}"><i class="fa-solid fa-user-pen"></i> View Review</a></li>
{% if apackage.joss %}
<li><a href="{{ apackage.archive }}" rel="permalink"><i class="fas fa-bookmark fa-fw"></i> JOSS Approved</a></li>
{% endif %}
{% if apackage.partners contains "astropy" %}
<li><a href="communities/astropy.html"><i class="fa-solid fa-check-double"></i> <img src="https://img.shields.io/badge/Affiliated-Astropy-orange.svg?style=flat" alt="Astropy" /></a></li>
{% endif %}
{% if apackage.active == false %}
<li><i class="fa-solid fa-box-archive"></i> Archived</li>
{% endif %}
</ul>
<hr>
{% if include.community %}
<h4>Package stats</h4>
<ul>
<li><strong>All Time Contributors:</strong> {{ apackage.gh_meta.contrib_count }}</li>
<li><strong>Last Commit date:</strong> {{ apackage.gh_meta.last_commit }}</li>
<li><strong>Date Created:</strong> {{ apackage.gh_meta.created_at }}</li>
</ul>
<div class="package-card__content">
<h3 class="package-card__title" itemprop="name">
{{ apackage.package_name }}
</h3>

<div class="package-card__meta">
<i class="fas fa-feather" aria-hidden="true"></i>
<span class="package-card__maintainers">
{% if apackage.all_current_maintainers %}
{% for maintainer in apackage.all_current_maintainers %}
<a href="https://github.com/{{ maintainer.github_username }}" rel="maintainer" target="_blank">
{% if maintainer.name %}
{{ maintainer.name }}{% if forloop.last == false %},{% endif %}
{% else %}
{{ maintainer.github_username }}{% if forloop.last == false %},{% endif %}
{% endif %}
</a>
{% endfor %}
{% elsif apackage.submitting_author.name != 'Name' %}
<a href="https://github.com/{{ apackage.submitting_author.github_username }}" rel="maintainer" target="_blank">
{{ apackage.submitting_author.name }}
</a>
{% else %}
<a href="https://github.com/{{ apackage.submitting_author.github_username }}" rel="maintainer" target="_blank">
{{ apackage.submitting_author.github_username }}
</a>
{% endif %}
</article>
</span>
</div>

<div class="package-card__description" itemprop="description">
{{ apackage.package_description | markdownify }}
</div>

<ul class="package-card__links">
<li><a href="{{ apackage.repository_link }}" rel="permalink"><i class="fab fa-github" aria-hidden="true"></i> View Code</a></li>
{% if apackage.gh_meta.documentation %}
<li><a href="{{ apackage.gh_meta.documentation }}" rel="permalink"><i class="fas fa-book-open" aria-hidden="true"></i> View Docs</a></li>
{% endif %}
<li><a href="{{ apackage.issue_link }}"><i class="fa-solid fa-user-pen" aria-hidden="true"></i> View Review</a></li>
{% if apackage.joss %}
<li><a href="{{ apackage.archive }}" rel="permalink"><i class="fas fa-bookmark fa-fw" aria-hidden="true"></i> JOSS Approved</a></li>
{% endif %}
{% if apackage.partners contains "astropy" %}
<li><a href="communities/astropy.html"><i class="fa-solid fa-check-double" aria-hidden="true"></i> <img src="https://img.shields.io/badge/Affiliated-Astropy-orange.svg?style=flat" alt="Astropy" /></a></li>
{% endif %}
{% if apackage.active == false %}
<li class="package-card__archived"><i class="fa-solid fa-box-archive" aria-hidden="true"></i> Archived</li>
{% endif %}
</ul>
</div>
</div>
95 changes: 53 additions & 42 deletions _includes/people-grid.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,63 +1,74 @@

<div class="element-item cards {% for aType in aperson.contributor_type %}
{% assign use_isotope = include.isotope | default: false %}

{% if use_isotope == true %}
<div class="element-item cards people-card {% for aType in aperson.contributor_type %}
{{ aType }}
{% endfor %}
" data-category="data">
{% endfor %}" data-category="data">
{% else %}
<div class="cards people-card">
{% endif %}
<div class="people-card__content">
{% if aperson.github_image_id %}
<div class="person_img">
<img src="https://avatars1.githubusercontent.com/u/{{ aperson.github_image_id }}?s=400&v=4" alt="GitHub photo of {{ aperson.name }}">
</div>
{% endif %}

<article class="archive__item" itemscope="" itemtype="https://schema.org/CreativeWork">
{% if aperson.github_image_id %}
<div class="person_img">
<img src="https://avatars1.githubusercontent.com/u/{{ aperson.github_image_id }}?s=400&v=4" alt="GitHub photo of {{ aperson.name }}">
</div>
<h4 class="person_name">
<a href="https://github.com/{{ aperson.github_username }}" rel="permalink">
{% if aperson.name %}
{{ aperson.name }}
{% else %}
@{{ aperson.github_username }}
{% endif %}
<h4 class="person_name" itemprop="headline">
<a href="https://github.com/{{ aperson.github_username }}" rel="permalink">
{% if aperson.name %}
{{ aperson.name }}
{% else %}
@{{ aperson.github_username }}
{% endif %}
</a>
</h4>
<p class="page__meta">
{% if aperson.partners %}
</a>
</h4>

<p class="page__meta">
{% if aperson.partners %}
<span>
{{ aperson.partners | join: ', ' }}
</span>
{% endif %}
</p>
<p class="page__meta">
{% endif %}
</p>

<p class="page__meta">
{% if aperson.title %}
<span>
{{ aperson.title | join: ', ' }}
</span>
<span>
{{ aperson.title | join: ', ' }}
</span>
{% endif %}
</p>
<p class="contrib_org" itemprop="organization"> {{ aperson.organization }} </p>
<div class="ppl_social">
</p>

<p class="contrib_org">{{ aperson.organization }}</p>

<div class="ppl_social">
{% if aperson.twitter %}
<a href="https://www.twitter.com/{{ aperson.twitter }}">
<span class="fa-brands fa-twitter" title="Click to view {{ aperson.title }}'s Twitter account"></span>
</a>
<a href="https://www.twitter.com/{{ aperson.twitter }}">
<span class="fa-brands fa-twitter" title="Click to view {{ aperson.title }}'s Twitter account"></span>
</a>
{% endif %}
{% if aperson.github_username %}
<a href="https://github.com/{{ aperson.github_username }}"><span class="fa-brands fa-github" title="Click to view {{ aperson.title }}'s GitHub account"></span>
</a>
<a href="https://github.com/{{ aperson.github_username }}">
<span class="fa-brands fa-github" title="Click to view {{ aperson.title }}'s GitHub account"></span>
</a>
{% endif %}
{% if aperson.website %}
<a href="{{ aperson.website }}" data-proofer-ignore><span class="fa-solid fa-blog" title="Click to view {{ aperson.title }}'s Website"></span>
</a>
<a href="{{ aperson.website }}" data-proofer-ignore>
<span class="fa-solid fa-blog" title="Click to view {{ aperson.title }}'s Website"></span>
</a>
{% endif %}
{% if aperson.orcidid %}
<a href="https://orcid.org/{{ aperson.orcidid }}"><span class="fa-brands fa-orcid" title="Click to view {{ aperson.title }} on fa-orcid"></span>
</a>
<a href="https://orcid.org/{{ aperson.orcidid }}">
<span class="fa-brands fa-orcid" title="Click to view {{ aperson.title }} on fa-orcid"></span>
</a>
{% endif %}

{% if aperson.mastodon %}
<a href="{{ aperson.mastodon }}">
<span class="fa-brands fa-mastodon" title="{{ aperson.name }} is on Mastadon"></span>
</a>
<a href="{{ aperson.mastodon }}">
<span class="fa-brands fa-mastodon" title="{{ aperson.name }} is on Mastadon"></span>
</a>
{% endif %}
</div>
</article>
</div>
</div>
10 changes: 5 additions & 5 deletions _pages/contributors.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ by an expert team of volunteer advisory members who help steer the direction of

<div class="grid executive-council-grid">
{% for aperson in advisory_sorted %}
{% include people-grid.html %}
{% include people-grid.html %}
{% endfor %}
</div>

Expand All @@ -46,7 +46,7 @@ the organization.

<div class="grid advisory-council-grid">
{% for aperson in advisory_working %}
{% include people-grid.html %}
{% include people-grid.html %}
{% endfor %}
</div>

Expand All @@ -64,7 +64,7 @@ leadership councils.
<div class="grid emeritus-council-grid">
{% for aperson in emeritus_advisory %}
{{ aperson.person_name }}
{% include people-grid.html %}
{% include people-grid.html %}
{% endfor %}
</div>

Expand All @@ -81,7 +81,7 @@ leadership councils.

<div class="grid advisory-council-grid">
{% for aperson in editorial %}
{% include people-grid.html %}
{% include people-grid.html %}
{% endfor %}
</div>

Expand Down Expand Up @@ -117,6 +117,6 @@ pyOpenSci has a diverse and vibrant community of pythonistas! To date,
<div class="grid-isotope">
<div class="grid-sizer"></div>
{% for aperson in ppl_sorted %}
{% include people-grid.html %}
{% include people-grid.html isotope=true %}
{% endfor %}
</div>
6 changes: 4 additions & 2 deletions _pages/python-packages.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,8 @@ To view packages affiliated with our partner communities that are a part of ourp
</div>

<!-- Active Packages -->
<div class="grid-isotope">
<div class="grid-isotope package-grid-isotope">
<div class="grid-sizer"></div>
{% for apackage in packages_sorted %}
{% if apackage.active == true %}
{% include package-grid.html %}
Expand All @@ -60,7 +61,8 @@ To view packages affiliated with our partner communities that are a part of ourp
Archived packages are packages that have successfully completed [pyOpenSci's software peer review process](https://www.pyopensci.org/about-peer-review/index.html) but are no longer maintained. [Check out our software maintenance policy for how we determine when a package becomes archived.](https://www.pyopensci.org/software-peer-review/our-process/policies.html#package-maintenance-and-maintainer-responsiveness)

<!-- Archived Packages -->
<div class="grid-isotope">
<div class="grid-isotope package-grid-isotope">
<div class="grid-sizer"></div>
{% for apackage in packages_sorted %}
{% if apackage.active == false %}
{% include package-grid.html %}
Expand Down
36 changes: 23 additions & 13 deletions _sass/minimal-mistakes/_pyos-grid.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,30 +163,19 @@ $colors: (
// do not adjust the display or structure of the cards element.
/* Package cards splash */

.element-item.cards {
padding: 0;
margin: 2em;
}

// Base card styles - shared by both people and package cards
.cards {
top: 0px;
position: relative;
background-color: #fff;//#fcfbf5;
text-decoration: none;
z-index: 0;
z-index: 1;
overflow: hidden;
font-size: .8em;
box-shadow: 0 4px 10px rgba(0, 0, 0, 0.15);
margin-right: auto!important;
margin-left: auto!important;

// Remove padding from top for person images
.person_img {
margin-top: 0;
margin-left: 0;
margin-right: 0;
}

&__image {
max-height: calc($small / 3);
overflow: hidden;
Expand Down Expand Up @@ -549,3 +538,24 @@ $colors: (

}
}

// Isotope grid cards - override base .cards auto margins that break isotope layout
.grid-isotope .element-item.cards {
margin-left: 0 !important;
margin-right: 0 !important;
}

// People cards in isotope grid - specific styling
.grid-isotope .element-item.cards.people-card {
padding: 0;
margin: 8px;

// Remove padding from top for person images
.person_img {
margin-top: 0;
margin-left: 0;
margin-right: 0;
}
}

// Package cards in isotope grid - styles are now in _pyos-isotope.scss
Loading