Skip to content

bug: Fix dropdown quirk mobile and desktop #778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lwasser merged 2 commits into from
Dec 26, 2025
Merged

bug: Fix dropdown quirk mobile and desktop #778

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf33750
bug: fix drop down non mobile position
lwasser Dec 26, 2025
ecabb38
bug: fix mobile mode
lwasser Dec 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 39 additions & 25 deletions _sass/minimal-mistakes/_pyos-dropdown.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
========================================================================== */

.nav__links {
overflow: hidden;
overflow: visible;
margin: 0 auto;
padding: 0;
display: flex;
Expand Down Expand Up @@ -50,13 +50,16 @@
display: flex;
flex-direction: column;
align-items: flex-start;
padding: 0 1em;
margin-top: 3em;
top: 90%;
padding: 1em;
margin-top: 0.5em;
top: 100%;
left: 5%;
right: 5%;
gap: 0;
font-size: 1.2em;
gap: 0.25em;
font-size: 1em;
height: auto;
max-height: calc(100vh - 6rem);
overflow-y: auto;
background-color: $pyos-white;
z-index: 1;
border: 1px solid $border-color;
Expand All @@ -68,32 +71,50 @@
0 2px 4px 0 rgba(0, 0, 0, 0.16),
0 2px 10px 0 rgba(0, 0, 0, 0.12);

> li {
width: 100%;
padding: 0.5em 0;
display: block;
align-items: initial;
}

a {
float: none;
display: block;
text-align: left;
}

li {
width: 100%;
padding: 0.5em 0;
font-size: 1em;
color: $nav-font-color;
}

.dropdown {
float: none;
width: 100%;
position: static;
overflow: visible;

.dropbtn {
width: 100%;
text-align: left;
display: block;
padding: 1em 0;

padding: 0.75em 0;
cursor: pointer;
}

.dropdown-content {
display: none;
position: relative;
width: 100%;
min-width: 100%;
position: relative;
box-shadow: unset;
box-shadow: none;
background-color: transparent;
padding-left: 1em;
margin-top: 0.5em;
top: auto;
left: 0;

&.open {
display: block;
}
}
}
}
Expand Down Expand Up @@ -121,11 +142,6 @@
}
}

/* Force nav links fonts to be same size */
.nav__links a {
font-size: 0.9em !important;
}

/* Dropdown container for nav links */
.dropdown {
float: left;
Expand All @@ -152,8 +168,9 @@
box-shadow: 0px 8px 16px 0px rgba(0, 0, 0, 0.2);
z-index: 1;
width: 100%;
top: 100%;
transition: all 0.25s ease-in;
transform: translateY(-10px);
transform: translateY(0px);
position: absolute;

&.open {
Expand Down Expand Up @@ -321,11 +338,8 @@
}

/* Nav links goes vertical in responsive mode */
.nav__links .vertical {
position: absolute;
.nav__links.vertical {
display: flex;
flex-direction: column;
align-items: flex-start;
}

.hamburger__btn-toggle {
Expand Down