Return xsize and ysize metadata from the ODIMhdf5 reader

[jorahu]

ODIMhdf5 reader has been missing xsize and ysize in the importing stage. I know it could be easily calculated from the x and y coordinates and the xpixelsize and ypixelsize, but why add the calculation when the variables are present already in the metadata.

[dnerini]

hi @jorahu, many thanks. My main concern is about keeping the output consistent across all readers. If you think adding the xsize and ysize metadata would be valuable for the users, then why not doing it for all readers? As you say, these are easily computed on the fly from the other metadata...

[dnerini]

Including these would imply providing these two metedata for all available readers

[jorahu]

Hey. I now see your point more clearly. First, apologies for this incomplete idea, this is the first time I am using the pull request. This idea might have been better off as a suggestion under Issues probably. Sorry for that. As I am only using the ODIM importer, where this xsize and ysize is a mandatory variable, I thought it's easier to read that parameter from metadata (as it must be there anyway) than to calculate it. But sure, it might not be the case for all the other importer options that pysteps supports. I apparently only looked it from my narrow perspective. As I don't have good knowledge of all the other importers I am certainly not able to fix them all to proceed with this. Probably better to discard this idea at this point as the parameters can be found/calculated from the data itself.

[codecov]

Codecov Report

❌ Patch coverage is 33.33333% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.81%. Comparing base (a6a6e5b) to head (b20a935).

Files with missing lines	Patch %	Lines
pysteps/io/importers.py	33.33%	6 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #535      +/-   ##
==========================================
- Coverage   83.84%   83.81%   -0.04%     
==========================================
  Files         168      168              
  Lines       14630    14639       +9     
==========================================
+ Hits        12267    12270       +3     
- Misses       2363     2369       +6     

Flag	Coverage Δ
unit_tests	83.81% <33.33%> (-0.04%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.