Extract gil management functions to separate header#2845
Merged
rwgk merged 1 commit intopybind:masterfrom Feb 23, 2021
Merged
Conversation
virtuald
force-pushed
the
mv-gil
branch
3 times, most recently
from
d3adbe1 to
918c909
Compare
henryiii
approved these changes
Feb 5, 2021
Collaborator
henryiii
left a comment
henryiii
left a comment
There was a problem hiding this comment.
I'm generally in favor of more, smaller files with better separation. Makes it easier to refactor, find what you are looking for, include just the right part, etc.
Collaborator
|
CI all green! I'll merge this now. Thanks @henryiii for your approval! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Move gil_scoped_* to gil.h so that it can be used from cast.h, required for #2839
Suggested changelog entry:
N/A