Use if constexpr #5389
Closed
Use if constexpr #5389
+36
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyyever
force-pushed
the
if_constexpr
branch
from
c01273e to
fac33f3
Compare
cyyever
force-pushed
the
if_constexpr
branch
9 times, most recently
from
4050387 to
efbd12c
Compare
Collaborator
|
I'd rather not make these changes, but I'm open to other opinions.
But AFAIK it does very little or nothing for optimization purposes. My opinion in this particular case: some extra code noise, no clear benefit. |
Signed-off-by: cyy <cyyever@outlook.com>
cyyever
force-pushed
the
if_constexpr
branch
from
8de751c to
11c7f13
Compare
Collaborator
|
This is just wasting our limited CI capacity. As I commented before, I don't think this PR is worth merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add "if constexpr" support.
📚 Documentation preview 📚: https://pybind11--5389.org.readthedocs.build/