return nullptr after PYBIND11_CATCH_INIT_EXCEPTIONS#57
Open
danigm wants to merge 1 commit intopybind:masterfrom
Open
return nullptr after PYBIND11_CATCH_INIT_EXCEPTIONS#57danigm wants to merge 1 commit intopybind:masterfrom
danigm wants to merge 1 commit intopybind:masterfrom
Conversation
After this commit [1], it's better to return nullptr because the return was removed from the Macro. [1] pybind/pybind11@974eba7
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Oct 28, 2025
https://build.opensuse.org/request/show/1314000 by user dgarcia + anag_factory - Add 0001-return-nullptr-after-PYBIND11_CATCH_INIT_EXCEPTIONS.patch gh#pybind/pybind11_abseil#57. This fixes the build with latest pybind11.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After this commit [1], it's better to return nullptr because the return was removed from the Macro.
[1] pybind/pybind11@974eba7