Add client hello callback related functions#13634
Open
Conversation
Tarnum-tst
suggested changes
Oct 10, 2025
schwabe
force-pushed
the
add_client_hello_callback
branch
from
de59175 to
8e49ebb
Compare
Author
|
@Tarnum-tst I assume that is about not having names for the parameter? If yes I fixed that. If there was something else wrong, please point it out to me. |
schwabe
force-pushed
the
add_client_hello_callback
branch
from
8e49ebb to
346e8af
Compare
alex
approved these changes
Oct 11, 2025
Member
alex
left a comment
alex
left a comment
There was a problem hiding this comment.
lgtm pending confirmation on the pyopenssl side
This exposes the OpenSSL functions SSL_CTX_set_client_hello_cb, SSL_client_hello_get0_ext and SSL_client_hello_get1_extensions_present. These are required to implement to the client hello callback functionality in pyOpenSSL. Signed-off-by: Arne Schwabe <arne@rfc2549.org>
schwabe
force-pushed
the
add_client_hello_callback
branch
from
346e8af to
3c985f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This exposes the OpenSSL functions SSL_CTX_set_client_hello_cb, SSL_client_hello_get0_ext and SSL_client_hello_get1_extensions_present.
These are required to implement to the client hello callback functionality in pyOpenSSL.