Update test to avoid tripping on non-text blocks. #4880
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JorjMcKie
approved these changes
Jan 26, 2026
JorjMcKie
approved these changes
Jan 26, 2026
The test extracts text and images from a page. It drops any images that are not fully included within the mediabox. Accordingly the test never sees any images, so works fine. In a new MuPDF commit, when the CLIP flag is sent, images are restricted to the clip region - i.e. they always fit within the mediabox, hence we now have images appearing in the list. The fix is to skip any non-text blocks in the test.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have no idea why this is now necessary.