Add windows venv generator #274
Merged
+239
−74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanking13
added
the
integration
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…dide-build into windows-venv-support
Member
Author
|
Okay, I think this started to work now. I guess in the future we will need to migrate to distlib instead of using the batch file as batch file is creating a lot of issues... |
hoodmane
reviewed
Dec 17, 2025
hoodmane
approved these changes
Jan 2, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add venv generator for windows.
It mostly reuses the logic in linux, while patching the linux bash scripts into windows.
I also changed how pip in invoked: previously pip wrapper was embeded in a bash script, but I extracted it out into a searate Python file (
_pip_wrapper.py) as embedding doesn't work very well in Windows.