Conversation
…nan since nan!= nan. Adding it in the allclose() call
- Inline test strings now add import statements at top of test - Created 2 tests for import functionality (one with standard import, one with from import, both with aliases) - Added meeting notes from 10-31
|
Thanks for your contribution, @hanse7962. Can you please fix the CI build, before we can take a look? |
Contributor
Author
|
Sure thing. I'll take a look and update the request once it's fixed. |
Contributor
|
Don't worry @owolabileg, I'm on top of this project (which just started not long ago). We will implement more stuff and polish the code before calling for a broader code review. We're just trying to get the CI tests running as a signal through this PR. |
Apparently, they are incompatible with pre Python 3.10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inline tests support imported libraries.