allow to limit ansible hosts with regex#785
Open
marwin1991 wants to merge 3 commits intopytest-dev:mainfrom
Open
allow to limit ansible hosts with regex#785marwin1991 wants to merge 3 commits intopytest-dev:mainfrom
marwin1991 wants to merge 3 commits intopytest-dev:mainfrom
Conversation
Author
|
@philpep ping :) |
Author
|
If this change is okay I will create docs |
osk-8
reviewed
Nov 21, 2024
testinfra/backend/ansible.py
Outdated
Comment on lines
94
to
95
| from ansible.parsing.dataloader import DataLoader | ||
| from ansible.inventory.manager import InventoryManager |
There was a problem hiding this comment.
I think it will be clearer to bring the imports to the top of the file
|
++1 to that change - seems useful |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, I have added simple change
urllib.parse.unquote(host)for host variable to allow using regex.I think is kinda not the best way, I was thinking about option
--ansible-limitand inansble.pywe could change methodget_hostsas follows:what do you think?