Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the handling of
readOnlyandwriteOnlyproperties in the OpenAPI schema validator. It ensures that properties explicitly set toFalsefor these keywords are correctly ignored during validation, and adds tests to verify this behavior.Validation logic improvements:
write_readOnlyfunction inopenapi_schema_validator/_keywords.pyto immediately return if thereadOnlyflag is not set, preventing unnecessary validation errors whenreadOnlyisFalse.read_writeOnlyfunction inopenapi_schema_validator/_keywords.pyto immediately return if thewriteOnlyflag is not set, preventing unnecessary validation errors whenwriteOnlyisFalse.Testing enhancements:
test_read_only_falseandtest_write_only_falsetotests/integration/test_validators.pyto ensure that properties withreadOnly: FalseorwriteOnly: Falseare validated without errors.