Discriminator handling for non-object instances#249
Merged
Conversation
p1c2u
force-pushed
the
fix/discriminator-handing-for-non-object-instances
branch
from
028e5c9 to
f5b364f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the handling and validation of the
discriminatorkeyword in OpenAPI schema validation. The main focus is on ensuring that the discriminator logic is only applied to objects and on adding corresponding test coverage for this scenario.Discriminator validation improvements:
handle_discriminatorinopenapi_schema_validator/_keywords.pyto check if the instance is an object before applying discriminator logic, yielding aValidationErrorif not.Test coverage enhancements:
tests/integration/test_validators.pyto assert that aValidationErroris raised with the correct message when the discriminator is used on a non-object instance.