-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Neon and sepia filters #9341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
matheusmpff
wants to merge
23
commits into
python-pillow:main
Choose a base branch
from
matheusmpff:feat-neon-and-sepia-filters
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+133
−1
Open
Neon and sepia filters #9341
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
62ed526
Add sepia function logic and documentation
637bc99
Add sobel edge detector logic and documentation
0807c85
Add glow effect function implementation
e15b398
Add function to apply color for the glow effect
3494fcb
Add blend function that blend the layer with original image
c0511fa
Add function that apply neon glow effect
032183e
Import ImageFIlter
9bde470
Add tests for sepia, sobel and glow effect functions
fa37192
Import cast
8856b03
Add autofunction for sepia, sobel and neon_effect functions
2663478
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 52d7d5e
Merge branch 'main' into feat-neon-and-sepia-filters
radarhere 168c0bf
Updated type hints
radarhere 74266a5
Only convert mode when needed
radarhere 8883018
Inlined _glow_mask
radarhere 0e2b57a
Colorize image band by band
radarhere d241df1
Inlined _neon_colorize
radarhere 20b3ccb
Replaced _neon_blend with Image.blend
radarhere 2b946f6
Merge pull request #2 from radarhere/feat-neon-and-sepia-filters
matheusmpff 9060a85
Test sepia with non-RGB image
radarhere 73277d7
Corrected param documentation
radarhere c6572cf
Updated param description
radarhere a66d730
Swap loop order
radarhere File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just want to confirm - you're sure the
Kyvalues are correct? Looking at https://en.wikipedia.org/wiki/Sobel_operator#Formulation, one might expect thatKyshould actually be[[-1, -2, -1], [0, 0, 0], [1, 2, 1]]There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had used an inverted kernel for the Sobel operator in the y direction. The right one is the
[[-1, -2, -1], [0, 0, 0], [1, 2, 1]]. But I think in the implementation we use the absolute values ofgyso I think the results will be the same. It should be great to change for the correct one