Publically re-export __version__#3186
Conversation
A5rocks
left a comment
There was a problem hiding this comment.
IMO we should encourage importlib.metadata (eg in the newsfragment). But this is fine as a bugfix to something we thought worked.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3186 +/- ##
===============================================
Coverage 100.00000% 100.00000%
===============================================
Files 124 124
Lines 18460 18460
Branches 1216 1216
===============================================
Hits 18460 18460
🚀 New features to boost your workflow:
|
well, it does work currently so this isn't really a bugfix per se. By publicly re-exporting it we're making it part of the official API, so I think perhaps this shouldn't be done at all? |
The comment implies we thought it would work, and that it does in pyright. Also, is this PR even necessary?: |
|
Try with |
In this pull request, we publicly re-export
__version__. This came up when working on python-trio/trio-websocket#193, where some of the unit test code looks at Trio's version for version-dependent things and mypy is not happy about accessing__version__.