Skip to content

Commit 69d2c98

Browse files
mattwang44sobolevn
andauthored
fix(argparse): apply suggestions from code review
Co-authored-by: sobolevn <mail@sobolevn.me>
1 parent c14013f commit 69d2c98

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

Lib/argparse.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -966,7 +966,7 @@ def format_usage(self):
966966

967967
def _check_compatibility(self, container):
968968
if '-' not in container.prefix_chars:
969-
raise ValueError(f"BooleanOptionalAction requires '-' in prefix_chars.")
969+
raise ValueError("BooleanOptionalAction requires '-' in prefix_chars.")
970970

971971

972972
class _StoreAction(Action):

Lib/test/test_argparse.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -797,7 +797,7 @@ def test_invalid_name(self):
797797

798798
def test_prefix_chars_incompatibility(self):
799799
parser = argparse.ArgumentParser(prefix_chars='+')
800-
with self.assertRaises(ValueError) as cm:
800+
with self.assertRaisesRegex(ValueError, ...) as cm:
801801
parser.add_argument('++foo', action=argparse.BooleanOptionalAction)
802802
self.assertEqual(str(cm.exception),
803803
"BooleanOptionalAction requires '-' in prefix_chars.")

0 commit comments

Comments
 (0)