-
-
Notifications
You must be signed in to change notification settings - Fork 33.8k
gh-101178: Add Ascii85, base85, and Z85 support to binascii #102753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
05ae5ad
aa06c5d
6377440
6c0e4a3
ce4773c
4072e3b
bc9217f
2c40ba0
fd9eaf7
4746d18
d075593
6d65fec
a241356
0df9a40
60fbd7c
a070887
167e83e
01df442
7885918
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,79 @@ | ||||||
| """C accelerator wrappers for originally pure-Python parts of base64.""" | ||||||
|
|
||||||
| from binascii import Error, a2b_ascii85, a2b_base85, b2a_ascii85, b2a_base85 | ||||||
|
|
||||||
|
|
||||||
| # Base 85 functions in base64 silently convert input to bytes. | ||||||
| # Copy the conversion logic from base64 to avoid circular imports. | ||||||
|
|
||||||
| bytes_types = (bytes, bytearray) # Types acceptable as binary data | ||||||
|
|
||||||
|
|
||||||
| def _bytes_from_decode_data(s): | ||||||
| if isinstance(s, str): | ||||||
| try: | ||||||
| return s.encode('ascii') | ||||||
| except UnicodeEncodeError: | ||||||
| raise ValueError('string argument should contain only ASCII characters') | ||||||
| if isinstance(s, bytes_types): | ||||||
| return s | ||||||
| try: | ||||||
| return memoryview(s).tobytes() | ||||||
| except TypeError: | ||||||
| raise TypeError("argument should be a bytes-like object or ASCII " | ||||||
| "string, not %r" % s.__class__.__name__) from None | ||||||
|
|
||||||
|
|
||||||
| def _bytes_from_encode_data(b): | ||||||
| return b if isinstance(b, bytes_types) else memoryview(b).tobytes() | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The discussion by @serhiy-storchaka seems to have been resolved with the conclusion that the pure-Python base-85-related functions from I'll therefore turn
However, to follow your comment here a bit: The type conversion logic is replicated from the existing The logic in The new additions ( Can you or someone else verify that the C type conversion logic in
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oh so it was something that was already there. Ok, sorry for the noise. I was more worried about the fact that a TypeError was caught during decoding but not during encoding. |
||||||
|
|
||||||
|
|
||||||
| # Functions in binascii raise binascii.Error instead of ValueError. | ||||||
|
|
||||||
| def a85encode(b, *, foldspaces=False, wrapcol=0, pad=False, adobe=False): | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No, the existing Python implementation does not use positional-only parameters. Changing this is a separate issue.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Arf, ok :( I thought it was incorrectly c/c. |
||||||
| b = _bytes_from_encode_data(b) | ||||||
| try: | ||||||
| return b2a_ascii85(b, fold_spaces=foldspaces, | ||||||
| wrap=adobe, width=wrapcol, pad=pad) | ||||||
| except Error as e: | ||||||
| raise ValueError(e) from None | ||||||
|
|
||||||
|
|
||||||
| def a85decode(b, *, foldspaces=False, adobe=False, ignorechars=b' \t\n\r\v'): | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| b = _bytes_from_decode_data(b) | ||||||
| try: | ||||||
| return a2b_ascii85(b, fold_spaces=foldspaces, | ||||||
| wrap=adobe, ignore=ignorechars) | ||||||
| except Error as e: | ||||||
| raise ValueError(e) from None | ||||||
|
|
||||||
| def b85encode(b, pad=False): | ||||||
| b = _bytes_from_encode_data(b) | ||||||
| try: | ||||||
| return b2a_base85(b, pad=pad, newline=False) | ||||||
| except Error as e: | ||||||
| raise ValueError(e) from None | ||||||
|
|
||||||
|
|
||||||
| def b85decode(b): | ||||||
| b = _bytes_from_decode_data(b) | ||||||
| try: | ||||||
| return a2b_base85(b, strict_mode=True) | ||||||
| except Error as e: | ||||||
| raise ValueError(e) from None | ||||||
|
|
||||||
|
|
||||||
| def z85encode(s, pad=False): | ||||||
| s = _bytes_from_encode_data(s) | ||||||
| try: | ||||||
| return b2a_base85(s, pad=pad, newline=False, z85=True) | ||||||
| except Error as e: | ||||||
| raise ValueError(e) from None | ||||||
|
|
||||||
|
|
||||||
| def z85decode(s): | ||||||
| s = _bytes_from_decode_data(s) | ||||||
| try: | ||||||
| return a2b_base85(s, strict_mode=True, z85=True) | ||||||
| except Error as e: | ||||||
| raise ValueError(e) from None | ||||||
Uh oh!
There was an error while loading. Please reload this page.