gh-96471: Correct docs for queue shutdown raises#115838
gh-96471: Correct docs for queue shutdown raises#115838gvanrossum merged 5 commits intopython:mainfrom
Conversation
4fdeb68 to
63bdd42
Compare
63bdd42 to
c1bcb5d
Compare
gvanrossum
left a comment
There was a problem hiding this comment.
Thanks! Two nits and then I'll merge this. (I feel bad that I didn't catch this in review.)
gvanrossum
left a comment
There was a problem hiding this comment.
Please fix the nits I called out.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
I have made the requested changes; please review again |
Queue.join()andQueue.task_done()documentation (including doc-string)Queue.shutdown()behaviour (it doesn't raise itself, but causes other methods to raise)Queue.task_done()is called byQueue.shutdown(immediate=True)for each item in the queueCaused by: #104750
📚 Documentation preview 📚: https://cpython-previews--115838.org.readthedocs.build/