Fix override value in os.rst #123522
Merged
Fix override value in os.rst #123522
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bedevere-app
bot
added
docs
| .. versionchanged:: 3.13 | ||
| If :option:`-X cpu_count <-X>` is given or :envvar:`PYTHON_CPU_COUNT` is set, | ||
| :func:`cpu_count` returns the overridden value *n*. | ||
| :func:`cpu_count` returns the override value *n*. |
Contributor
There was a problem hiding this comment.
The language is weird either way, may be 'overriding value'
Contributor
Author
There was a problem hiding this comment.
Hi there. Shouldn't it be like "return value" used in these docs? (English is not my native language, so I could be mixing different things)
Member
|
You need to update the branch to fix the CI. |
rffontenelle
force-pushed
the
patch-5
branch
from
92b10dd to
664ea44
Compare
Contributor
Author
|
Thanks, Stan. Updated against current main branch. @corona10 It seems Vitor requested your review. Can you please take a look? |
corona10
approved these changes
Dec 27, 2025
|
Thanks @rffontenelle for the PR, and @corona10 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 27, 2025
(cherry picked from commit f5e11facf2d3d89ea8c387376d5889b959c60d82) Co-authored-by: Rafael Fontenelle <rffontenelle@users.noreply.github.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 27, 2025
(cherry picked from commit f5e11fa) Co-authored-by: Rafael Fontenelle <rffontenelle@users.noreply.github.com>
|
GH-143211 is a backport of this pull request to the 3.14 branch. |
|
GH-143212 is a backport of this pull request to the 3.13 branch. |
corona10
pushed a commit
that referenced
this pull request
Dec 27, 2025
corona10
pushed a commit
that referenced
this pull request
Dec 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
python -X cpu_count=ncommand line, n value is not overridden by anything. It actually overrides the defaultos.cpu_count()'s return value. So the text should say "override value" instead of "overridden value".Please backport to 3.13
📚 Documentation preview 📚: https://cpython-previews--123522.org.readthedocs.build/