Skip to content

Conversation

@tomasr8
Copy link
Member

@tomasr8 tomasr8 commented May 2, 2025

This is a followup to #133048

This PR adds more tests to msgfmt.py:

  • general syntax error tests (mainly unclosed strings and invalid plural syntax)
  • semantic errors such incorrect ordering of msgid/msgstr etc.., invalid plural indices and duplicate entries.

I verified that these are rejected by GNU's msgfmt.

Note that some tests are commented out. That is because msgfmt.py is currently accepting these as valid.
In a followup PR, I am planning to fix its parser and then we'll be able to uncomment all of theses cases.

@bedevere-app bedevere-app bot added the tests Tests in the Lib/test dir label May 2, 2025
@bedevere-app bedevere-app bot mentioned this pull request May 2, 2025
18 tasks
@tomasr8 tomasr8 requested a review from serhiy-storchaka May 2, 2025 17:30
@tomasr8 tomasr8 requested a review from serhiy-storchaka May 4, 2025 20:15
@tomasr8
Copy link
Member Author

tomasr8 commented Jul 19, 2025

@serhiy-storchaka Do you think you could have another look? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants