gh-82665 Mention that HTMLParser.handle_starttag value can be None #134312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All commit authors signed the Contributor License Agreement. |
|
GH-134333 is a backport of this pull request to the 3.14 branch. |
emmatyping
added
needs backport to 3.13
Comment on lines
+137
to
+138
| have been replaced. If a boolean attribute is encountered, the *value* for the | ||
| ``(name, value)`` attribute pair will be ``None``. |
Member
There was a problem hiding this comment.
Boolean attributes can also be written as disabled=disabled or even disabled="". When the value is absent, this is called empty attribute. This is syntax, not semantic.
Suggested change
| have been replaced. If a boolean attribute is encountered, the *value* for the | |
| ``(name, value)`` attribute pair will be ``None``. | |
| have been replaced. For empty attributes, *value* is ``None``. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds documentation that specifies the behavior of HTMLParser.handle_starttag when a boolean attribute is parsed.
Since there is no value for the standard "key - value" format, "None" is placed into the tuple as the corresponding value for the boolean attribute.
📚 Documentation preview 📚: https://cpython-previews--134312.org.readthedocs.build/