Skip to content

gh-134674: fix: ast.MatchStar.name incorrectly having class-level default value #134676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hunterhogan wants to merge 2,314 commits into from
Closed

gh-134674: fix: ast.MatchStar.name incorrectly having class-level default value #134676

hunterhogan wants to merge 2,314 commits into from

Conversation

@hunterhogan
Copy link
Contributor

@hunterhogan hunterhogan commented May 25, 2025 •
edited by github-actions bot
Loading

Fixes gh-134674

Problem

ast.MatchStar.name incorrectly appears to have a class-level default value when using ast.dump(). The issue causes ast.MatchStar(name=None) to display as MatchStar() instead of the expected MatchStar(name=None).

Solution

Change the ASDL definition of MatchStar, and add MatchStar to the special cases list in ast.dump() alongside Constant and MatchSingleton.

📚 Documentation preview 📚: https://cpython-previews--134676.org.readthedocs.build/

miss-islington and others added 30 commits April 12, 2025 10:42
@miss-islington @StanFromIreland
[3.13] gh-123441: Update Belorussian spelling (GH-132409) (GH-132432)
17b6139 
(cherry picked from commit ad3bbe8)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@miss-islington @adorilson
@vstinner @AlexWaygood @picnixz @skirpichev @serhiy-storchaka
[3.13] gh-58211: Add tests for the __self__ attribute of builtins f…
70c4bd6 
…unctions (GH-113575) (#132437)

gh-58211: Add tests for  the `__self__` attribute of builtins functions (GH-113575)

---------
(cherry picked from commit 891465f)

Co-authored-by: Adorilson Bezerra <adorilson@gmail.com>
Co-authored-by: Victor Stinner <vstinner@python.org>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@miss-islington @da-woods
[3.13] Docs: Fix specifications of gcvisitobjects_t (GH-132433) (#1…
1884a3b 
…32441)

Docs: Fix specifications of `gcvisitobjects_t` (GH-132433)

`gcvisitobjects_t` callbacks should return 1 for the iteration to continue instead of 0.
(cherry picked from commit 1e5798e)

Co-authored-by: da-woods <dw-git@d-woods.co.uk>
@miss-islington @serhiy-storchaka
[3.13] gh-132185: Speed up expanduser() test with large password data…
f943376 
…base (GH-132231) (GH-132443)

Use only a limited number of randomly selected entries.
(cherry picked from commit 842ab81)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@kumaraditya303
[3.13] gh-132213: use relaxed atomics for set hash (#132447)
67b1c76
@serhiy-storchaka
[3.13] gh-132429: Fix support of Bluetooth sockets on NetBSD and Drag…
5be7505 
…onFly BSD (GH-132431) (GH-132458)

Also fix a compiler warning on FreeBSD.
(cherry picked from commit f2f86d3)
@miss-islington @Yzi-Li
[3.13] Fix a typo in c-api/typeobj.rst (GH-132317) (#132464)
244a642 
Fix a typo in c-api/typeobj.rst (GH-132317)
(cherry picked from commit f69b344)

Co-authored-by: Yongzi Li <1538321957@qq.com>
@miss-islington @felixscherz
[3.13] gh-132354: document return value for asyncio.Task.cancel (GH…
ff66901 
…-132374) (#132465)

gh-132354: document return value for `asyncio.Task.cancel` (GH-132374)
(cherry picked from commit 64b066a)

Co-authored-by: Felix Scherz <felixwscherz@gmail.com>
@tomasr8
[3.13] gh-131927: Prevent emitting compiler warnings twice (GH-131993) (
4ff5d88 
GH-132463)

(cherry picked from commit 3d08c8a)
@vsajip
[3.13] gh-132106: Ensure that running `logging.handlers.QueueListener… (
1dcdac6 
GH-132471)

Cherry-picked using 5863cd7
@serhiy-storchaka
[3.13] gh-132099: Fix documentation for the BTPROTO_HCI protocol (GH-…
54e1b63 
…132118) (GH-132482)

(cherry picked from commit 1d97488)
@miss-islington @Tapeline
[3.13] gh-132111: Document dataclasses.InitVar (GH-132446) (#132483)
d021b71 
gh-132111: Document dataclasses.InitVar (GH-132446)
(cherry picked from commit 281fc33)

Co-authored-by: Tapeline <mail@tapeline.dev>
@miss-islington
[3.13] gh-101100: Fix sphinx warnings in library/plistlib.rst (GH-1…
f206b98 
…32422) (#132485)

Co-authored-by: Yuki Kobayashi <drsuaimqjgar@gmail.com>
@miss-islington @serhiy-storchaka
[3.13] gh-124986: Fix test_no_leaking in test_subprocess on NetBSD an…
ff9198d 
…d FreeBSD (GH-132476) (GH-132498)

On platforms where the file descriptor limit is larger than FD_SETSIZE
that test was always skipped (FreeBSD) or always failing (NetBSD).
(cherry picked from commit f7b24ff)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@tomasr8
[3.13] gh-132435: Test syntax warnings in a finally block (GH-132436) (…
5f1eaff 
…GH-132503)

(cherry picked from commit 887eabc)
@miss-islington @kumaraditya303
[3.13] gh-86513: improve docs of loop.call_exception_handler (GH-132466…
fd0bba6 
…) (#132487)

gh-86513: improve docs of loop.call_exception_handler (GH-132466)
(cherry picked from commit ce75351)

Co-authored-by: Kumar Aditya <kumaraditya@python.org>
@miss-islington @picnixz
[3.13] gh-132515: de-duplicate `test_dataclass_derived_generic_from_s…
a50aa33 
…lotted_base` (GH-132516) (#132518)

gh-132515: de-duplicate `test_dataclass_derived_generic_from_slotted_base` (GH-132516)
(cherry picked from commit 45c447b)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@serhiy-storchaka
[3.13] gh-132099: Harmonize Bluetooth address handling (GH-132486) (G…
d321b6e 
…H-132497)

Now all protocols always accept the Bluetooth address as string and
getsockname() always returns the Bluetooth address as string.

* BTPROTO_SCO now accepts not only bytes, but str.
* BTPROTO_SCO now checks address for embedded null.
* On *BSD, BTPROTO_HCI now accepts str instead of bytes.
* On FreeBSD, getsockname() for BTPROTO_HCI now returns str instead of bytes.
* On NetBSD and DragonFly BSD, BTPROTO_HCI now checks address for embedded null.
(cherry picked from commit 1fc1df8)
@vstinner @rruuaanng
[3.13] gh-46236: Add missing PyUnicode_FromOrdinal() doc (#132040) (#…
866b635 
…132521)

gh-46236: Add missing PyUnicode_FromOrdinal() doc (#132040)

(cherry picked from commit 8768df2)

Co-authored-by: RUANG (James Roy) <longjinyii@outlook.com>
@miss-islington @jfly
[3.13] gh-131803: Clarify that you must register signal handlers for …
bdff88b 
…set_wakeup_fd (GH-131859) (#132522)

gh-131803: Clarify that you must register signal handlers for set_wakeup_fd (GH-131859)
(cherry picked from commit 939476b)

Co-authored-by: Jeremy Fleischman <jeremyfleischman@gmail.com>
@serhiy-storchaka
[3.13] gh-124476: Fix decoding from the locale encoding in the C.UTF-…
f218549 
…8 locale (GH-132477) (ПР-132528)

(cherry picked from commit 102f825)
@miss-islington @sobolevn @vstinner
[3.13] gh-132176: Fix crash on type() when tuple subclass passed …
6d48194 
…as `bases` (GH-132212) (#132548)

gh-132176: Fix crash on `type()` when `tuple` subclass passed as `bases` (GH-132212)
(cherry picked from commit b6c552f)

Co-authored-by: sobolevn <mail@sobolevn.me>
Co-authored-by: Victor Stinner <vstinner@python.org>
@miss-islington
[3.13] Fix argument order in multinomial() example (gh-132557) (gh-13…
11617d5 
…2560)
@miss-islington @wrongnull
@StanFromIreland @Eclips4
[3.13] gh-114713: Handle case of an empty string passed to `zoneinfo.…
a3a3bfd 
…ZoneInfo` (GH-114731) (#132563)

gh-114713: Handle case of an empty string passed to `zoneinfo.ZoneInfo` (GH-114731)
(cherry picked from commit 884df11)

Co-authored-by: Bogdan Romanyuk <65823030+wrongnull@users.noreply.github.com>
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
@miss-islington @AA-Turner
[3.13] Docs: Synchronise indexsidebar.html with docsbuild-scripts (…
2a1a337 
…GH-132567) (#132573)

Docs: Synchronise ``indexsidebar.html`` with docsbuild-scripts (GH-132567)
(cherry picked from commit 4f10b93)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@miss-islington @serhiy-storchaka
[3.13] gh-132535: Fix resource warnings in test_timeout (GH-132572) (G…
08faa2a 
…H-132580)

They were emitted if internet connection was not available.
(cherry picked from commit 82f74eb)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@miss-islington @serhiy-storchaka
[3.13] gh-127591: Fix altering environment in test_urllib2 (unsetting…
8128bcf 
… no_proxy) (GH-132584) (GH-132585)

(cherry picked from commit 8b7cb94)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@miss-islington @sobolevn
[3.13] gh-130941: Fix configparser parsing values with `allow_no_va…
ee8f681 
…lue` and `interpolation` set (GH-130949) (#132588)

gh-130941: Fix `configparser` parsing values with `allow_no_value` and `interpolation` set (GH-130949)
(cherry picked from commit c35c735)

Co-authored-by: sobolevn <mail@sobolevn.me>
@miss-islington @vstinner
[3.13] gh-130052: Fix search_map_for_section() error handling (GH-132594
ff3f658 
) (#132598)

gh-130052: Fix search_map_for_section() error handling (GH-132594)

* Don't call close() if the file descriptor is negative.
* If close() fails, chain the existing exception.
(cherry picked from commit 014c7f9)

Co-authored-by: Victor Stinner <vstinner@python.org>
@miss-islington @JelleZijlstra
[3.13] typing: Add missing test case for Protocol inheritance (GH-132597
88d95c3 
) (#132603)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
This was referenced May 25, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ast.MatchStar.name incorrectly has class-level default value