Skip to content

gh-135629: rewrite language reference section on except* to improve clarity #136150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iritkatriel merged 6 commits into from
Sep 16, 2025
Merged

gh-135629: rewrite language reference section on except* to improve clarity #136150

iritkatriel merged 6 commits into from
Sep 16, 2025

Conversation

@iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Jun 30, 2025 •
edited by github-actions bot
Loading

@bedevere-app bedevere-app bot added awaiting core review docs Documentation in the Doc dir skip news labels Jun 30, 2025
@github-project-automation github-project-automation bot moved this to Todo in Docs PRs Jun 30, 2025
@bedevere-app bedevere-app bot mentioned this pull request Jun 30, 2025
Closed
@iritkatriel
Copy link
Member Author

iritkatriel commented Jun 30, 2025

@mandeep is this better?

@mandeep
Copy link
Contributor

mandeep commented Jul 2, 2025

@iritkatriel This reads a lot better. Thanks for making the change. One small adjustment I think could be beneficial is breaking apart the long first paragraph into multiple smaller paragraphs.

mandeep
mandeep reviewed Jul 5, 2025
View reviewed changes
picnixz
picnixz reviewed Aug 4, 2025
View reviewed changes
Copy link
Member

@picnixz picnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could suppress one or two links and add a backref to sys.exception.

iritkatriel and others added 2 commits August 4, 2025 17:51
@iritkatriel @picnixz
Apply suggestions from code review
f686a29 
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@iritkatriel
Merge remote-tracking branch 'upstream/main' into pythongh-135629
8f5f50e
@iritkatriel iritkatriel merged commit a651ec9 into python:main Sep 16, 2025
27 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs Sep 16, 2025
@iritkatriel iritkatriel added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Sep 17, 2025
@miss-islington-app
Copy link

miss-islington-app bot commented Sep 17, 2025

Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link

miss-islington-app bot commented Sep 17, 2025

Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 17, 2025
@iritkatriel @miss-islington
pythongh-135629: rewrite language reference section on except* to imp…
f2c7637 
…rove clarity (pythonGH-136150)

(cherry picked from commit a651ec9)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 17, 2025
@iritkatriel @miss-islington
pythongh-135629: rewrite language reference section on except* to imp…
1acf7ff 
…rove clarity (pythonGH-136150)

(cherry picked from commit a651ec9)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Sep 17, 2025

GH-139059 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Sep 17, 2025
@bedevere-app
Copy link

bedevere-app bot commented Sep 17, 2025

GH-139060 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Sep 17, 2025
@iritkatriel iritkatriel added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Sep 17, 2025
@miss-islington-app
Copy link

miss-islington-app bot commented Sep 17, 2025

Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

miss-islington-app bot commented Sep 17, 2025

Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link

miss-islington-app bot commented Sep 17, 2025

Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington-app
Copy link

miss-islington-app bot commented Sep 17, 2025

Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 17, 2025
@iritkatriel @miss-islington
pythongh-135629: rewrite language reference section on except* to imp…
36f6093 
…rove clarity (pythonGH-136150)

(cherry picked from commit a651ec9)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
@miss-islington-app
Copy link

miss-islington-app bot commented Sep 17, 2025

Sorry @iritkatriel, I had trouble completing the backport.
Please retry by removing and re-adding the "needs backport to 3.13" label.
Please backport backport using cherry_picker on the command line.

cherry_picker a651ec95241c25161d525499a739f01bfe527895 3.13

@miss-islington-app
Copy link

miss-islington-app bot commented Sep 17, 2025

Sorry, @iritkatriel, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker a651ec95241c25161d525499a739f01bfe527895 3.11

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 17, 2025
@iritkatriel @miss-islington
pythongh-135629: rewrite language reference section on except* to imp…
4782b9f 
…rove clarity (pythonGH-136150)

(cherry picked from commit a651ec9)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
@miss-islington-app
Copy link

miss-islington-app bot commented Sep 17, 2025

Sorry @iritkatriel, I had trouble completing the backport.
Please retry by removing and re-adding the "needs backport to 3.14" label.
Please backport backport using cherry_picker on the command line.

cherry_picker a651ec95241c25161d525499a739f01bfe527895 3.14

@miss-islington-app
Copy link

miss-islington-app bot commented Sep 17, 2025

Sorry, @iritkatriel, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker a651ec95241c25161d525499a739f01bfe527895 3.12

iritkatriel added a commit that referenced this pull request Sep 17, 2025
@miss-islington @iritkatriel
[3.13] gh-135629: rewrite language reference section on except* to im…
f91884e 
…prove clarity (GH-136150) (#139060)

gh-135629: rewrite language reference section on except* to improve clarity (GH-136150)
(cherry picked from commit a651ec9)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
AA-Turner pushed a commit that referenced this pull request Oct 7, 2025
@miss-islington @iritkatriel
[3.14] gh-135629: rewrite language reference section on except* to im…
572e433 
…prove clarity (GH-136150) (#139059)

gh-135629: rewrite language reference section on except* to improve clarity (GH-136150)
(cherry picked from commit a651ec9)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
@StanFromIreland StanFromIreland removed needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Oct 27, 2025
@StanFromIreland
Copy link
Member

StanFromIreland commented Oct 27, 2025

Triage: 3.13/3.14 backports have been completed, do we still want to backport to 3.11/3.12?

@hugovk hugovk removed needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Nov 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixz picnixz picnixz left review comments

@willingc willingc Awaiting requested review from willingc willingc is a code owner

@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

+1 more reviewer

@mandeep mandeep mandeep left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@iritkatriel iritkatriel

Labels

docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@iritkatriel @mandeep @StanFromIreland @picnixz @hugovk