gh-135468: Improve BaseHandler.http_error_default() parameter descriptions
#136797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All commit authors signed the Contributor License Agreement. |
bedevere-app
bot
added
awaiting review
docs
Contributor
Author
|
@AA-Turner Thanks for the help and the review. |
AA-Turner
approved these changes
Jul 19, 2025
Member
AA-Turner
left a comment
AA-Turner
left a comment
There was a problem hiding this comment.
We could possibly use :param: here in the future, but this is an improvement.
A
AA-Turner
added
needs backport to 3.13
|
Thanks @valeriogianella for the PR, and @AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
AA-Turner
changed the title
BaseHandler.http_error_default() parameter descriptions
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 19, 2025
…er descriptions (pythonGH-136797) (cherry picked from commit 57acd65) Co-authored-by: Valerio Gianella <49408327+valeriogianella@users.noreply.github.com> Co-authored-by: Adam Turner <9087854+aa-turner@users.noreply.github.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 19, 2025
…er descriptions (pythonGH-136797) (cherry picked from commit 57acd65) Co-authored-by: Valerio Gianella <49408327+valeriogianella@users.noreply.github.com> Co-authored-by: Adam Turner <9087854+aa-turner@users.noreply.github.com>
|
GH-136825 is a backport of this pull request to the 3.14 branch. |
|
GH-136826 is a backport of this pull request to the 3.13 branch. |
hugovk
pushed a commit
that referenced
this pull request
Jul 22, 2025
hugovk
pushed a commit
that referenced
this pull request
Jul 22, 2025
taegyunkim
pushed a commit
to taegyunkim/cpython
that referenced
this pull request
Aug 4, 2025
…er descriptions (python#136797) Co-authored-by: Adam Turner <9087854+aa-turner@users.noreply.github.com>
Agent-Hellboy
pushed a commit
to Agent-Hellboy/cpython
that referenced
this pull request
Aug 19, 2025
…er descriptions (python#136797) Co-authored-by: Adam Turner <9087854+aa-turner@users.noreply.github.com>
kumaraditya303
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 9, 2025
…parameter descriptions (pythonGH-136797) (python#136825) Co-authored-by: Valerio Gianella <49408327+valeriogianella@users.noreply.github.com> Co-authored-by: Adam Turner <9087854+aa-turner@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
urllib.request.HTTPRedirectHandlerdocumentation useshdrsinstead ofheaders#135468📚 Documentation preview 📚: https://cpython-previews--136797.org.readthedocs.build/