Skip to content

gh-44538: Mention nested classes/functions in doctest docs #137870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ZeroIntensity merged 5 commits into from
Aug 18, 2025
Merged

gh-44538: Mention nested classes/functions in doctest docs #137870

ZeroIntensity merged 5 commits into from
Aug 18, 2025

Conversation

@johnslavik
Copy link
Member

@johnslavik johnslavik commented Aug 17, 2025 •
edited by github-actions bot
Loading

@bedevere-app bedevere-app bot added awaiting review docs Documentation in the Doc dir skip news labels Aug 17, 2025
@github-project-automation github-project-automation bot moved this to Todo in Docs PRs Aug 17, 2025
@bedevere-app bedevere-app bot mentioned this pull request Aug 17, 2025
Closed
ZeroIntensity
ZeroIntensity reviewed Aug 17, 2025
View reviewed changes
ZeroIntensity
ZeroIntensity reviewed Aug 17, 2025
View reviewed changes
johnslavik and others added 3 commits August 18, 2025 00:53
@johnslavik @ZeroIntensity
Review 1
20fc71a 
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
@johnslavik
Review 2
479eeae
@johnslavik
Use clearer language
54cebea
@johnslavik
Copy link
Member Author

johnslavik commented Aug 18, 2025

@ZeroIntensity I rephrased it a bit, should be less icky to read now

sharktide
sharktide reviewed Aug 18, 2025
View reviewed changes
ZeroIntensity
ZeroIntensity approved these changes Aug 18, 2025
View reviewed changes
Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@johnslavik
Copy link
Member Author

johnslavik commented Aug 18, 2025

Will that close the 18-year-old issue? 🚀

sharktide
sharktide approved these changes Aug 18, 2025
View reviewed changes
Copy link
Contributor

@sharktide sharktide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZeroIntensity ZeroIntensity merged commit 138ed6d into python:main Aug 18, 2025
31 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs Aug 18, 2025
@ZeroIntensity ZeroIntensity added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Aug 18, 2025
@miss-islington-app
Copy link

miss-islington-app bot commented Aug 18, 2025

Thanks @bswck for the PR, and @ZeroIntensity for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

miss-islington-app bot commented Aug 18, 2025

Thanks @bswck for the PR, and @ZeroIntensity for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 18, 2025
@johnslavik @miss-islington
pythongh-44538: Mention nested classes/functions in doctest docs (pyt…
fa28e9c 
…honGH-137870)

(cherry picked from commit 138ed6d)

Co-authored-by: Bartosz Sławecki <bartosz@ilikepython.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 18, 2025
@johnslavik @miss-islington
pythongh-44538: Mention nested classes/functions in doctest docs (pyt…
52ed357 
…honGH-137870)

(cherry picked from commit 138ed6d)

Co-authored-by: Bartosz Sławecki <bartosz@ilikepython.com>
@bedevere-app
Copy link

bedevere-app bot commented Aug 18, 2025

GH-137917 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Aug 18, 2025
@bedevere-app
Copy link

bedevere-app bot commented Aug 18, 2025

GH-137918 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Aug 18, 2025
ZeroIntensity pushed a commit that referenced this pull request Aug 18, 2025
@miss-islington @johnslavik
[3.13] gh-44538: Mention nested classes/functions in doctest docs (GH…
d188257 
…-137870) (GH-137917)

gh-44538: Mention nested classes/functions in doctest docs (GH-137870)
(cherry picked from commit 138ed6d)

Co-authored-by: Bartosz Sławecki <bartosz@ilikepython.com>
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@johnslavik @Agent-Hellboy
pythongh-44538: Mention nested classes/functions in doctest docs (pyt…
0dcb27a 
…honGH-137870)
hugovk pushed a commit that referenced this pull request Aug 27, 2025
@miss-islington @johnslavik
[3.14] gh-44538: Mention nested classes/functions in doctest docs (GH…
27a2152 
…-137870) (#137918)

Co-authored-by: Bartosz Sławecki <bartosz@ilikepython.com>
kumaraditya303 pushed a commit to miss-islington/cpython that referenced this pull request Sep 9, 2025
@miss-islington @johnslavik @kumaraditya303
[3.14] pythongh-44538: Mention nested classes/functions in doctest do…
3b3c9a7 
…cs (pythonGH-137870) (python#137918)

Co-authored-by: Bartosz Sławecki <bartosz@ilikepython.com>
@johnslavik johnslavik deleted the nested-doctests-ignored branch December 2, 2025 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZeroIntensity ZeroIntensity ZeroIntensity approved these changes

+1 more reviewer

@sharktide sharktide sharktide approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@johnslavik @ZeroIntensity @sharktide