[3.14] gh-133125: Clarify ZipInfo.date_time attribute documentation (GH-136082) #138077
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ythonGH-136082) Specifically, clarify that ZipInfo.date_time pulls the datetime information from the central directory, and that times are interpreted as local time. (cherry picked from commit 282e885) Co-authored-by: Kentaro Jay Takahashi <64148935+KentaroJay@users.noreply.github.com> Co-authored-by: Emma Smith <emma@emmatyping.dev>
bedevere-app
bot
added
awaiting review
docs
emmatyping
approved these changes
Aug 22, 2025
Member
|
This can probably wait until 3.14 is unlocked to merge. |
Member
|
Thanks, docs are generally fine to go in the RC. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically, clarify that ZipInfo.date_time pulls the datetime information from the central directory, and that times are interpreted as local time.
(cherry picked from commit 282e885)
Co-authored-by: Kentaro Jay Takahashi 64148935+KentaroJay@users.noreply.github.com
Co-authored-by: Emma Smith emma@emmatyping.dev
zipfile: docs should document whatZipInfo.date_timeactually is #133125📚 Documentation preview 📚: https://cpython-previews--138077.org.readthedocs.build/